netdev - Re: pull-request: wireless-drivers-next-2021-12-07

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad06fddfcc8bef222fecf69b8a9c7effd8cc9db5.camel@coelho.fi>
Date:   Sun, 19 Dec 2021 11:09:47 +0200
From:   Luca Coelho <luca@...lho.fi>
To:     Kalle Valo <kvalo@...nel.org>,
        Loic Poulain <loic.poulain@...aro.org>
Cc:     Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        linux-wireless@...r.kernel.org
Subject: Re: pull-request: wireless-drivers-next-2021-12-07

On Wed, 2021-12-08 at 17:58 +0100, Loic Poulain wrote:
> Hi Kalle,
> 
> On Wed, 8 Dec 2021 at 17:21, Kalle Valo <kvalo@...nel.org> wrote:
> > 
> > Jakub Kicinski <kuba@...nel.org> writes:
> > 
> > > On Wed, 08 Dec 2021 10:00:15 +0200 Kalle Valo wrote:
> > > > Jakub Kicinski <kuba@...nel.org> writes:
> > > Yeah, scroll down, there is a diff of the old warnings vs new ones, and
> > > a summary of which files have changed their warning count:
> > > 
> > > +      2 ../drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
> > > +      3 ../drivers/net/wireless/intel/iwlwifi/mei/main.c
> > > -      1 ../drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> > > +      2 ../drivers/net/wireless/intel/iwlwifi/mvm/ops.c
> > > -      2 ../drivers/net/wireless/microchip/wilc1000/wlan.c
> > 
> > Ah, that makes it easier.
> > 
> > > So presumably these are the warnings that were added:
> > > 
> > > drivers/net/wireless/intel/iwlwifi/mei/main.c:193: warning: cannot
> > > understand function prototype: 'struct '
> > > drivers/net/wireless/intel/iwlwifi/mei/main.c:1784: warning: Function
> > > parameter or member 'cldev' not described in 'iwl_mei_probe'
> > > drivers/net/wireless/intel/iwlwifi/mei/main.c:1784: warning: Function
> > > parameter or member 'id' not described in 'iwl_mei_probe'
> > 
> > Luca, please take a look and send a patch. I'll then apply it directly
> > to wireless-drivers-next.

Kalle, as we agreed, I sent 4 patches fixes this errors/warnings in
iwlwifi.

--
Cheers,
Luca.