netdev - Re: [PATCH net-next 11/13] net: dsa: realtek: rtl8367c: use GENMASK(n-1,0) instead of BIT(n)-1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJq09z4FGL43rr3TAxVXvFzFuuctRymdJb-0srZijebM-=KGLQ@mail.gmail.com>
Date:   Sun, 19 Dec 2021 17:28:04 -0300
From:   Luiz Angelo Daros de Luca <luizluca@...il.com>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     netdev@...r.kernel.org, Linus Walleij <linus.walleij@...aro.org>,
        Andrew Lunn <andrew@...n.ch>, vivien.didelot@...il.com,
        olteanv@...il.com,
        Alvin Šipraga <alsi@...g-olufsen.dk>,
        Arınç ÜNAL <arinc.unal@...nc9.com>
Subject: Re: [PATCH net-next 11/13] net: dsa: realtek: rtl8367c: use
 GENMASK(n-1,0) instead of BIT(n)-1

>
> Missing spaces between priv->num_ports, and -1 here, and the comma
> before 0 as well:
>                 mb->port_mask = GENMASK(priv->num_ports - 1, 0);
>
> is what we would expect to see.

v2 fixed that. Did I mess with v2 submission?

https://patchwork.kernel.org/project/netdevbpf/patch/20211218081425.18722-11-luizluca@gmail.com/

> --
> Florian