netdev - Re: [PATCH net-next v2 08/13] dt-bindings: net: dsa: realtek-mdio: document new interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Dec 2021 00:53:50 +0300
From:   Arınç ÜNAL <arinc.unal@...nc9.com>
To:     Luiz Angelo Daros de Luca <luizluca@...il.com>,
        netdev@...r.kernel.org
Cc:     linus.walleij@...aro.org, andrew@...n.ch, vivien.didelot@...il.com,
        f.fainelli@...il.com, olteanv@...il.com, alsi@...g-olufsen.dk
Subject: Re: [PATCH net-next v2 08/13] dt-bindings: net: dsa: realtek-mdio:
 document new interface

On 18/12/2021 11:14, Luiz Angelo Daros de Luca wrote:
> realtek-mdio is a new mdio driver for realtek switches that use
> mdio (instead of SMI) interface.
> 
> Reviewed-by: Arınç ÜNAL <arinc.unal@...nc9.com>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@...il.com>
> ---
>   .../bindings/net/dsa/realtek-mdio.txt         | 91 +++++++++++++++++++
>   MAINTAINERS                                   |  2 +-
>   2 files changed, 92 insertions(+), 1 deletion(-)
>   create mode 100644 Documentation/devicetree/bindings/net/dsa/realtek-mdio.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/dsa/realtek-mdio.txt b/Documentation/devicetree/bindings/net/dsa/realtek-mdio.txt
> new file mode 100644
> index 000000000000..71e0a3d09aeb
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/dsa/realtek-mdio.txt
> @@ -0,0 +1,91 @@
> +Realtek MDIO-based Switches
> +==========================
> +
> +Realtek MDIO-based switches use MDIO protocol as opposed to Realtek
> +SMI-based switches. The realtek-mdio driver is an mdio driver and it must
> +be inserted inside an mdio node.
> +
> +Required properties:
> +
> +- compatible: must be exactly one of (same as realtek-smi):
> +      "realtek,rtl8365mb" (4+1 ports)
> +      "realtek,rtl8366"               (not supported yet)
> +      "realtek,rtl8366rb" (4+1 ports)
> +      "realtek,rtl8366s"  (4+1 ports) (not supported yet)
> +      "realtek,rtl8367"               (not supported yet)
> +      "realtek,rtl8367b"              (not supported yet)
> +      "realtek,rtl8368s"  (8 port)    (not supported yet)
> +      "realtek,rtl8369"               (not supported yet)
> +      "realtek,rtl8370"   (8 port)    (not supported yet)
> +
> +Required properties:
> +- reg: MDIO PHY ID to access the switch
> +
> +Optional properties:
> +- realtek,disable-leds: if the LED drivers are not used in the
> +  hardware design this will disable them so they are not turned on
> +  and wasting power.
> +
> +See net/dsa/dsa.txt for a list of additional required and optional properties
> +and subnodes of DSA switches.
> +
> +Optional properties of dsa port:
> +
> +- realtek,ext-int: defines the external interface number (0, 1, 2). By default, 1.

You should introduce this with ("net: dsa: realtek: rtl8365mb: rename 
extport to extint, add "realtek,ext-int"") instead.