netdev - Re: [PATCH 1/2 (RESEND)] ath9k_htc: fix NULL pointer dereference at ath9k_htc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164001654478.2023.4087324781381514269.kvalo@kernel.org>
Date:   Mon, 20 Dec 2021 16:09:10 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
Cc:     Kalle Valo <kvalo@...eaurora.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, ath9k-devel@....qualcomm.com,
        linux-wireless@...r.kernel.org,
        Network Development <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/2 (RESEND)] ath9k_htc: fix NULL pointer dereference at
 ath9k_htc_rxep()

Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp> wrote:

> syzbot is reporting lockdep warning followed by kernel panic at
> ath9k_htc_rxep() [1], for ath9k_htc_rxep() depends on ath9k_rx_init()
> being already completed.
> 
> Since ath9k_htc_rxep() is set by ath9k_htc_connect_svc(WMI_BEACON_SVC)
>  from ath9k_init_htc_services(), it is possible that ath9k_htc_rxep() is
> called via timer interrupt before ath9k_rx_init() from ath9k_init_device()
> is called.
> 
> Since we can't call ath9k_init_device() before ath9k_init_htc_services(),
> let's hold ath9k_htc_rxep() no-op until ath9k_rx_init() completes.
> 
> Link: https://syzkaller.appspot.com/bug?extid=4d2d56175b934b9a7bf9 [1]
> Reported-by: syzbot <syzbot+4d2d56175b934b9a7bf9@...kaller.appspotmail.com>
> Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
> Tested-by: syzbot <syzbot+4d2d56175b934b9a7bf9@...kaller.appspotmail.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

2 patches applied to ath-next branch of ath.git, thanks.

b0ec7e55fce6 ath9k_htc: fix NULL pointer dereference at ath9k_htc_rxep()
8b3046abc99e ath9k_htc: fix NULL pointer dereference at ath9k_htc_tx_get_packet()

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/2b88f416-b2cb-7a18-d688-951e6dc3fe92@i-love.sakura.ne.jp/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches