netdev - Re: [PATCH v2 ipsec-next 2/2] xfrm: state and policy should fail if XFRMA_IF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211220083601.GO427717@gauss3.secunet.de>
Date:   Mon, 20 Dec 2021 09:36:01 +0100
From:   Steffen Klassert <steffen.klassert@...unet.com>
To:     Antony Antony <antony.antony@...unet.com>
CC:     Eyal Birger <eyal.birger@...il.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        "Jakub Kicinski" <kuba@...nel.org>, <netdev@...r.kernel.org>
Subject: Re: [PATCH v2 ipsec-next 2/2] xfrm: state and policy should fail if
 XFRMA_IF_ID 0

On Sun, Dec 12, 2021 at 11:35:00AM +0100, Antony Antony wrote:
> xfrm ineterface does not allow xfrm if_id = 0
> fail to create or update xfrm state and policy.
> 
> With this commit:
>  ip xfrm policy add src 192.0.2.1 dst 192.0.2.2 dir out if_id 0
>  RTNETLINK answers: Invalid argument
> 
>  ip xfrm state add src 192.0.2.1 dst 192.0.2.2 proto esp spi 1 \
>             reqid 1 mode tunnel aead 'rfc4106(gcm(aes))' \
>             0x1111111111111111111111111111111111111111 96 if_id 0
>  RTNETLINK answers: Invalid argument
> 
> v1->v2 change:
>  - add Fixes: tag
> 
> Fixes: 9f8550e4bd9d ("xfrm: fix disable_xfrm sysctl when used on xfrm interfaces")
> Signed-off-by: Antony Antony <antony.antony@...unet.com>

Also applied to the ipsec tree, thanks a lot!