netdev - Re: Issues with smsc95xx driver since a049a30fc27c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <YcBEgE589cf5DhJd@lunn.ch>
Date:   Mon, 20 Dec 2021 09:53:20 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Gabriel Hojda <ghojda@...urs.ro>
Cc:     Martyn Welch <martyn.welch@...labora.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: Issues with smsc95xx driver since a049a30fc27c

> # ip link set eth0 up
> # ip link show eth0
> 2: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP
> mode DEFAULT group default qlen 1000
>     link/ether ee:f1:a8:e7:0c:8f brd ff:ff:ff:ff:ff:ff
> 
> ... now link is up with the same mac address
> 
> # ifconfig eth0
> eth0: flags=4163<UP,BROADCAST,RUNNING,MULTICAST>  mtu 1500
>         inet6 2a02:2f09:3d09:1b00:ecf1:a8ff:fee7:c8f  prefixlen 64  scopeid
> 0x0<global>
>         inet6 fe80::ecf1:a8ff:fee7:c8f  prefixlen 64  scopeid 0x20<link>
>         inet6 fd00:cafe::c772:d58f:1061:4df3  prefixlen 64  scopeid
> 0x0<global>
>         inet6 fd00:cafe::ecf1:a8ff:fee7:c8f  prefixlen 64  scopeid
> 0x0<global>
>         inet6 2a02:2f09:3d09:1b00:eef4:bb1d:f9d5:febc  prefixlen 64  scopeid
> 0x0<global>

These make use of multicast. Router Advertisements are multicast, both
at L2 and L3, by the router to the Internet.

> # ping -6 -c 10 ipv6.l.google.com
> PING ipv6.l.google.com(ipv6.l.google.com (2a00:1450:400d:806::200e)) 56 data
> bytes
> From odroid (2a02:2f09:3d09:1b00:eef4:bb1d:f9d5:febc) icmp_seq=1 Destination
> unreachable: Address unreachable
> ...
> --- ipv6.l.google.com ping statistics ---
> 10 packets transmitted, 0 received, +7 errors, 100% packet loss, time 9311ms

ping uses unicast.

> ... neither does it work for my local router, so network layer 3 does not
> seem to work

I think it is still pointing towards L2 unicast.

> next, when i have time and if there's still no progress, i think i should
> try to insert:
> 
>         ret = smsc95xx_reset(dev);
> 	if (ret)
> 		goto free_pdata;
> 
> before
> 
> 	ret = phy_connect_direct(dev->net, pdata->phydev,
> 				 &smsc95xx_handle_link_change,
> 				 PHY_INTERFACE_MODE_MII);
> 
> in smsc95xx_bind() to try to emulate the old behavior for the first call to
> start_phy().

Yes, that will be in interesting experiment. Something in
smsc95xx_reset() is required.

	Andrew