netdev - Re: [PATCH net-next v2] mctp: emit RTM_NEWADDR and RTM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2f13e007f8e9deaa0fde187f7c1321e2703b9895.camel@codeconstruct.com.au>
Date:   Mon, 20 Dec 2021 10:30:12 +0800
From:   Matt Johnston <matt@...econstruct.com.au>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jeremy Kerr <jk@...econstruct.com.au>, netdev@...r.kernel.org,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next v2] mctp: emit RTM_NEWADDR and RTM_DELADDR

On Fri, 2021-12-17 at 11:42 -0800, Jakub Kicinski wrote:
> 	return NLMSG_ALIGN(sizeof(struct ifaddrmsg))
> > +		+ nla_total_size(4) // IFA_LOCAL
> > +		+ nla_total_size(4) // IFA_ADDRESS
> 
> why 4? The attributes are u8, no?
> 
> 
> > +	if (rc < 0)
> How about a customary WARN_ON_ONCE(rc == -EMSGSIZE) here?

Thanks for the review Jakub. Size 4 is a mistake, I'll send v3.

Cheers,
Matt
>