netdev - Re: Issues with smsc95xx driver since a049a30fc27c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 20 Dec 2021 11:37:54 +0100
From:   Markus Reichl <m.reichl@...etechno.de>
To:     Gabriel Hojda <ghojda@...urs.ro>, Andrew Lunn <andrew@...n.ch>
Cc:     Martyn Welch <martyn.welch@...labora.com>, netdev@...r.kernel.org,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        Steve Glendinning <steve.glendinning@...well.net>,
        UNGLinuxDriver@...rochip.com,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, stable@...nel.org
Subject: Re: Issues with smsc95xx driver since a049a30fc27c



Am 18.12.21 um 21:33 schrieb Gabriel Hojda:
> On 2021-12-18 20:32, Andrew Lunn wrote:
>>> O.K, stab in the dark. Does the hardware need to be programmed with
>>> the MAC address? When does this happen? If this is going wrong, it
>>> could explain the promisc mode. If the MAC address has not been
>>> programmed, it has no idea what packets are for itself. Put it into
>>> promisc mode, and it will receive everything, including what it is
>>> supposed to receive. But looking at the offending patch, it is not
>>> obvious how it has anything to do with MAC addresses. The only
>>> unbalanced change in that patch is that smsc95xx_reset(dev) has
>>> disappeared, not moved to somewhere else.
>>
>> Ah!
>>
>> smsc95xx_reset() calls smsc95xx_set_mac_address(). So that fits.
>> smsc95xx_reset() is also called in smsc95xx_bind(), but maybe that is
>> not enough?
>>
>>     Andrew
> hi Andrew,
> 
> the odroid-u3 has no preconfigured mac address. the kernel from the vendor is 
> patched to read a file in /etc and set the mac address read from it. with the 
> mainline kernel the interface gets a random mac address that can later be changed 
> by NetworkManager & Co. (as far as i know there's no 
> "smsc95xx.macaddr=xx:xx:xx:xx:xx:xx" kernel boot parameter).
> 
> u-boot should be able to set the mac addreess, but it doesn't even detect the 
> network interface and i get a message like "No NET interface" (even though i've 
> tried the steps at 
> https://github.com/ARM-software/u-boot/blob/master/doc/README.odroid).
> 
> Gabriel

Hi,

same issue on odroid-x2 which has no preconfigured mac address either.

I use plain Debian buster and bullseye with traditional
/etc/network/interfaces

auto eth0
     allow-hotplug eth0
     iface eth0 inet dhcp
         hwaddress ether c2:c5:aa:9e:aa:55
     iface eth0 inet6 dhcp


Gruß,
-- 
Markus Reichl