netdev - RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 21 Dec 2021 14:25:59 +0000
From:   "Chen, Mike Ximing" <mike.ximing.chen@...el.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "arnd@...db.de" <arnd@...db.de>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "pierre-louis.bossart@...ux.intel.com" 
        <pierre-louis.bossart@...ux.intel.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>
Subject: RE: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver


> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Tuesday, December 21, 2021 3:57 AM
> To: Chen, Mike Ximing <mike.ximing.chen@...el.com>
> Cc: linux-kernel@...r.kernel.org; arnd@...db.de; Williams, Dan J <dan.j.williams@...el.com>; pierre-
> louis.bossart@...ux.intel.com; netdev@...r.kernel.org; davem@...emloft.net; kuba@...nel.org
> Subject: Re: [RFC PATCH v12 01/17] dlb: add skeleton for DLB driver
> 
> On Tue, Dec 21, 2021 at 08:12:00AM +0100, Greg KH wrote:
> > On Tue, Dec 21, 2021 at 12:50:31AM -0600, Mike Ximing Chen wrote:
> > > +/* Copyright(C) 2016-2020 Intel Corporation. All rights reserved.
> > > +*/
> >
> > So you did not touch this at all in 2021?  And it had a copyrightable
> > changed added to it for every year, inclusive, from 2016-2020?
> >
> > Please run this past your lawyers on how to do this properly.
> 
> Ah, this was a "throw it over the fence at the community to handle for me before I go on vacation" type of
> posting, based on your autoresponse email that happened when I sent this.
> 
> That too isn't the most kind thing, would you want to be the reviewer of this if it were sent to you?  Please
> take some time and start doing patch reviews for the char/misc drivers on the mailing list before
> submitting any more new code.
> 
> Also, this patch series goes agains the internal rules that I know your company has, why is that?  Those
> rules are there for a good reason, and by ignoring them, it's going to make it much harder to get patches
> to be reviewed.
> 

I assume that you referred to the "Reviewed-by" rule from Intel. Since this is a RFC and we are seeking for
comments and guidance on our code structure, we thought it was appropriate to sent out patch set out
with a full endorsement from our internal reviewers. The questions I posted in the cover letter
(patch 00/17) are from the discussions with our internal reviewers.

I will take some days off as many people would do during this time of the year 😊, but will check mails daily
and response to questions/comments on the submission.

Thanks for your help.
Mike