netdev - Re: [PATCH -next V2] sysctl: returns -EINVAL when a negative value is passed to proc_doulongvec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6ec2155c-c976-4c9b-1975-c28792bb3144@huawei.com>
Date:   Tue, 21 Dec 2021 09:21:08 +0800
From:   "libaokun (A)" <libaokun1@...wei.com>
To:     Luis Chamberlain <mcgrof@...nel.org>
CC:     <akpm@...ux-foundation.org>, <keescook@...omium.org>,
        <yzaikin@...gle.com>, <ast@...nel.org>, <daniel@...earbox.net>,
        <andrii@...nel.org>, <kafai@...com>, <songliubraving@...com>,
        <yhs@...com>, <john.fastabend@...il.com>, <kpsingh@...nel.org>,
        <linux-kernel@...r.kernel.org>, <linux-fsdevel@...r.kernel.org>,
        <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <yukuai3@...wei.com>, Hulk Robot <hulkci@...wei.com>,
        Baokun Li <libaokun1@...wei.com>
Subject: Re: [PATCH -next V2] sysctl: returns -EINVAL when a negative value is
 passed to proc_doulongvec_minmax

在 2021/12/21 3:17, Luis Chamberlain 写道:
> On Mon, Dec 20, 2021 at 05:26:27PM +0800, Baokun Li wrote:
>> When we pass a negative value to the proc_doulongvec_minmax() function,
>> the function returns 0, but the corresponding interface value does not
>> change.
>>
>> we can easily reproduce this problem with the following commands:
>>      `cd /proc/sys/fs/epoll`
>>      `echo -1 > max_user_watches; echo $?; cat max_user_watches`
>>
>> This function requires a non-negative number to be passed in, so when
>> a negative number is passed in, -EINVAL is returned.
>>
>> Reported-by: Hulk Robot <hulkci@...wei.com>
>> Signed-off-by: Baokun Li <libaokun1@...wei.com>
> Acked-by: Luis Chamberlain <mcgrof@...nel.org>
>
>   Luis
> .

Thank you for your Ack.

-- 
With Best Regards,
Baokun Li