netdev - Re: [PATCH net] veth: ensure skb entering GRO are not cloned.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 17:10:30 +0100
From:   Paolo Abeni <pabeni@...hat.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev <netdev@...r.kernel.org>,
        Ignat Korchagin <ignat@...udflare.com>
Subject: Re: [PATCH net] veth: ensure skb entering GRO are not cloned.

On Wed, 2021-12-22 at 03:58 -0800, Eric Dumazet wrote:
> On Wed, Dec 22, 2021 at 3:06 AM Paolo Abeni <pabeni@...hat.com> wrote:
> > I thought about something similar, but I overlooked possible OoO or
> > behaviour changes when a packet socket is attached to the paired device
> > (as it would disable GRO).
> 
> Have you tried a pskb_expand_head() instead of a full copy ?
> Perhaps that would be enough, and keep all packets going through GRO to
> make sure OOO is covered.

Indeed it looks like it's enough. I'll do some more testing and I'll
send a v2 using pskb_expand_head().

Many thanks!

Paolo