netdev - Re: [PATCH net-next 1/2] codel: remove unnecessary sock.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 22 Dec 2021 07:56:05 +0200
From:   Kalle Valo <kvalo@...nel.org>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, pkshih@...ltek.com,
        ath11k@...ts.infradead.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] codel: remove unnecessary sock.h include

Jakub Kicinski <kuba@...nel.org> writes:

> Since sock.h is modified relatively often (60 times in the last
> 12 months) it seems worthwhile to decrease the incremental build
> work.
>
> CoDel's header includes net/inet_ecn.h which in turn includes net/sock.h.
> codel.h is itself included by mac80211 which is included by much of
> the WiFi stack and drivers. Removing the net/inet_ecn.h include from
> CoDel breaks the dependecy between WiFi and sock.h.
>
> Commit d068ca2ae2e6 ("codel: split into multiple files") moved all
> the code which actually needs ECN helpers out to net/codel_impl.h,
> the include can be moved there as well.
>
> This decreases the incremental build size after touching sock.h
> from 4999 objects to 4051 objects.
>
> Fix unmasked missing includes in WiFi drivers.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: kvalo@...nel.org
> CC: pkshih@...ltek.com
> CC: ath11k@...ts.infradead.org
> CC: linux-wireless@...r.kernel.org
> ---
>  drivers/net/wireless/ath/ath11k/debugfs.c  | 2 ++
>  drivers/net/wireless/realtek/rtw89/core.c  | 2 ++
>  drivers/net/wireless/realtek/rtw89/debug.c | 2 ++

Acked-by: Kalle Valo <kvalo@...nel.org>

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches