netdev - Re: [PATCH] can: softing_cs: fix memleak on registration failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YcMGcBqkSaZzo7uq@kroah.com>
Date:   Wed, 22 Dec 2021 12:05:20 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-can@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Subject: Re: [PATCH] can: softing_cs: fix memleak on registration failure

On Wed, Dec 22, 2021 at 11:48:43AM +0100, Johan Hovold wrote:
> In case device registration fails during probe, the driver state and the
> embedded platform device structure needs to be freed using
> platform_device_put() to properly free all resources (e.g. the device
> name).
> 
> Fixes: 0a0b7a5f7a04 ("can: add driver for Softing card")
> Cc: stable@...r.kernel.org      # 2.6.38
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---
>  drivers/net/can/softing/softing_cs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/can/softing/softing_cs.c b/drivers/net/can/softing/softing_cs.c
> index 2e93ee792373..e5c939b63fa6 100644
> --- a/drivers/net/can/softing/softing_cs.c
> +++ b/drivers/net/can/softing/softing_cs.c
> @@ -293,7 +293,7 @@ static int softingcs_probe(struct pcmcia_device *pcmcia)
>  	return 0;
>  
>  platform_failed:
> -	kfree(dev);
> +	platform_device_put(pdev);
>  mem_failed:
>  pcmcia_bad:
>  pcmcia_failed:
> -- 
> 2.32.0
> 

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>