netdev - Re: [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43f04a56-8f1e-6325-c9bb-31164a4fc6ee@intel.com>
Date:   Wed, 22 Dec 2021 13:34:31 +0100
From:   Cezary Rojewski <cezary.rojewski@...el.com>
To:     "David E. Box" <david.e.box@...ux.intel.com>,
        <gregkh@...uxfoundation.org>, <mustafa.ismail@...el.com>,
        <shiraz.saleem@...el.com>, <dledford@...hat.com>, <jgg@...pe.ca>,
        <leon@...nel.org>, <saeedm@...dia.com>, <davem@...emloft.net>,
        <kuba@...nel.org>, <vkoul@...nel.org>,
        <yung-chuan.liao@...ux.intel.com>,
        <pierre-louis.bossart@...ux.intel.com>, <mst@...hat.com>,
        <jasowang@...hat.com>
CC:     <andriy.shevchenko@...ux.intel.com>, <hdegoede@...hat.com>,
        <virtualization@...ts.linux-foundation.org>,
        <alsa-devel@...a-project.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-rdma@...r.kernel.org>
Subject: Re: [PATCH 0/4] driver_core: Auxiliary drvdata helper cleanup

On 2021-12-22 12:58 AM, David E. Box wrote:
> Depends on "driver core: auxiliary bus: Add driver data helpers" patch [1].
> Applies the helpers to all auxiliary device drivers using
> dev_(get/set)_drvdata. Drivers were found using the following search:
> 
>      grep -lr "struct auxiliary_device" $(grep -lr "drvdata" .)
> 
> Changes were build tested using the following configs:
> 
>      vdpa/mlx5:       CONFIG_MLX5_VDPA_NET
>      net/mlx53:       CONFIG_MLX5_CORE_EN
>      soundwire/intel: CONFIG_SOUNDWIRE_INTEL
>      RDAM/irdma:      CONFIG_INFINIBAND_IRDMA
>                       CONFIG_MLX5_INFINIBAND
> 
> [1] https://www.spinics.net/lists/platform-driver-x86/msg29940.html
> 
> David E. Box (4):
>    RDMA/irdma: Use auxiliary_device driver data helpers
>    soundwire: intel: Use auxiliary_device driver data helpers
>    net/mlx5e: Use auxiliary_device driver data helpers
>    vdpa/mlx5: Use auxiliary_device driver data helpers
> 
>   drivers/infiniband/hw/irdma/main.c                | 4 ++--
>   drivers/infiniband/hw/mlx5/main.c                 | 8 ++++----
>   drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 8 ++++----
>   drivers/soundwire/intel.c                         | 8 ++++----
>   drivers/soundwire/intel_init.c                    | 2 +-
>   drivers/vdpa/mlx5/net/mlx5_vnet.c                 | 4 ++--
>   6 files changed, 17 insertions(+), 17 deletions(-)

Changes look good, I did post one question regarding possible occurrence 
of dev_get_drvdata() not being accounted for in patch:
[PATCH 1/4] RDMA/irdma: Use auxiliary_device driver data helpers

However, it does look like a blocker so:

Reviewed-by: Cezary Rojewski <cezary.rojewski@...el.com>


For the record, I did scan the following files (users of struct 
auxiliary_device) from drivers/ directory for the missing occurrences 
and found only a single one (as mentioned earlier):

drivers/net/ethernet/mellanox/mlx5/core/dev.c
drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.c
drivers/net/ethernet/mellanox/mlx5/core/sf/dev/driver.c
drivers/net/ethernet/mellanox/mlx5/core/sf/dev/dev.h
drivers/net/ethernet/mellanox/mlx5/core/en_rep.c
drivers/net/ethernet/mellanox/mlx5/core/en_main.c
drivers/net/ethernet/intel/i40e/i40e_client.c
drivers/net/ethernet/intel/ice/ice.h
drivers/net/ethernet/intel/ice/ice_idc.c
drivers/infiniband/hw/irdma/main.c
drivers/infiniband/hw/irdma/i40iw_if.c
drivers/infiniband/hw/mlx5/main.c
drivers/infiniband/hw/mlx5/ib_rep.c
drivers/vdpa/mlx5/net/mlx5_vnet.c
drivers/gpu/drm/bridge/ti-sn65dsi86.c
drivers/soundwire/intel_init.c
drivers/soundwire/intel.c


Regards,
Czarek