[an error occurred while processing this directive]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

[an error occurred while processing this directive]

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211222165706.28089162@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Wed, 22 Dec 2021 16:57:06 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     conleylee@...mail.com
Cc:     davem@...emloft.net, mripard@...nel.org, wens@...e.org,
        netdev@...r.kernel.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] sun4i-emac.c: add dma support

On Wed, 22 Dec 2021 15:09:27 +0800 conleylee@...mail.com wrote:
> -#define DRV_NAME		"sun4i-emac"
> +#define DRV_NAME "sun4i-emac"
>  
> -#define EMAC_MAX_FRAME_LEN	0x0600
> +#define EMAC_MAX_FRAME_LEN 0x600
>  
>  #define EMAC_DEFAULT_MSG_ENABLE 0x0000
> -static int debug = -1;     /* defaults above */;
> +static int debug = -1; /* defaults above */
> +;
>  module_param(debug, int, 0);
>  MODULE_PARM_DESC(debug, "debug message flags");
>  
> @@ -69,24 +71,25 @@ MODULE_PARM_DESC(watchdog, "transmit timeout in milliseconds");
>   */
>  
>  struct emac_board_info {
> -	struct clk		*clk;
> -	struct device		*dev;
> -	struct platform_device	*pdev;
> -	spinlock_t		lock;
> -	void __iomem		*membase;
> -	u32			msg_enable;
> -	struct net_device	*ndev;
> -	struct sk_buff		*skb_last;
> -	u16			tx_fifo_stat;
> -
> -	int			emacrx_completed_flag;
> -
> -	struct device_node	*phy_node;
> -	unsigned int		link;
> -	unsigned int		speed;
> -	unsigned int		duplex;
> -
> -	phy_interface_t		phy_interface;
> +	struct clk *clk;
> +	struct device *dev;
> +	struct platform_device *pdev;
> +	spinlock_t lock;
> +	void __iomem *membase;
> +	u32 msg_enable;
> +	struct net_device *ndev;
> +	u16 tx_fifo_stat;
> +
> +	int emacrx_completed_flag;
> +
> +	struct device_node *phy_node;
> +	unsigned int link;
> +	unsigned int speed;
> +	unsigned int duplex;
> +
> +	phy_interface_t phy_interface;
> +	struct dma_chan *rx_chan;
> +	phys_addr_t emac_rx_fifo;

Please remove all the code formatting changes from the patch and repost.
It makes it hard to review the patch when most of it is an unrelated
whitespace modification.