netdev - Re: [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211223192256.1c91fe7a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 23 Dec 2021 19:22:56 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Coco Li <lixiaoyan@...gle.com>,
        Willem de Bruijn <willemb@...gle.com>
Cc:     netdev@...r.kernel.org, "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso
 segments

On Thu, 23 Dec 2021 19:19:22 -0800 Jakub Kicinski wrote:
> On Thu, 23 Dec 2021 22:24:40 +0000 Coco Li wrote:
> > The max number of UDP gso segments is intended to cap to
> > UDP_MAX_SEGMENTS, this is checked in udp_send_skb().
> > 
> > skb->len contains network and transport header len here, we should use
> > only data len instead.
> > 
> > This is the ipv6 counterpart to the below referenced commit,
> > which missed the ipv6 change
> > 
> > Fixes: 158390e45612 ("udp: using datalen to cap max gso segments")  
> 
> I'm gonna replace the Fixes tag with:
> 
> Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> 
> hope that's okay.

Or I'll fumble the git command and accidentally push as is... Whatever.