netdev - Re: [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso segments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+FuTSc3-bsLjz+qXKYZ_G-7yUTQnGguzE8mLVFDyXdwvaGFWA@mail.gmail.com>
Date:   Thu, 23 Dec 2021 22:48:50 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Coco Li <lixiaoyan@...gle.com>, netdev@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH net 1/2] udp: using datalen to cap ipv6 udp max gso segments

On Thu, Dec 23, 2021 at 10:23 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 23 Dec 2021 19:19:22 -0800 Jakub Kicinski wrote:
> > On Thu, 23 Dec 2021 22:24:40 +0000 Coco Li wrote:
> > > The max number of UDP gso segments is intended to cap to
> > > UDP_MAX_SEGMENTS, this is checked in udp_send_skb().
> > >
> > > skb->len contains network and transport header len here, we should use
> > > only data len instead.
> > >
> > > This is the ipv6 counterpart to the below referenced commit,
> > > which missed the ipv6 change
> > >
> > > Fixes: 158390e45612 ("udp: using datalen to cap max gso segments")
> >
> > I'm gonna replace the Fixes tag with:
> >
> > Fixes: bec1f6f69736 ("udp: generate gso with UDP_SEGMENT")
> >
> > hope that's okay.
>
> Or I'll fumble the git command and accidentally push as is... Whatever.

Thanks. I was in two minds which commit to use. From a backport to
stable point of view, it should not matter in practice.