netdev - Re: [PATCH net-next] ipv6: ioam: Support for Queue depth data field

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1276384477.245449661.1640349223295.JavaMail.zimbra@uliege.be>
Date:   Fri, 24 Dec 2021 13:33:43 +0100 (CET)
From:   Justin Iurman <justin.iurman@...ege.be>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, dsahern@...nel.org,
        yoshfuji@...ux-ipv6.org
Subject: Re: [PATCH net-next] ipv6: ioam: Support for Queue depth data field

On Dec 24, 2021, at 4:28 AM, Jakub Kicinski kuba@...nel.org wrote:
> On Thu, 23 Dec 2021 16:55:15 +0100 Justin Iurman wrote:
>> +		} else {
>> +			queue = skb_get_tx_queue(skb_dst(skb)->dev, skb);
>> +			qdisc_qstats_qlen_backlog(queue->qdisc, &qlen, &backlog);
>> +
>> +			*(__be32 *)data = cpu_to_be32(qlen);
>> +		}
>>  		data += sizeof(__be32);
>>  	}
>>  
> 
> sparse complains that:
> 
> net/ipv6/ioam6.c:729:56: warning: incorrect type in argument 1 (different
> address spaces)
> net/ipv6/ioam6.c:729:56:    expected struct Qdisc *sch
> net/ipv6/ioam6.c:729:56:    got struct Qdisc [noderef] __rcu *qdisc

Thanks for reporting, I indeed forgot to run sparse. I'm surprised the
bot did not report it, though. Sorry for that, will fix this in -v2.