netdev - Re: [PATCH] drivers: net: smc911x: Fix wrong check for irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 25 Dec 2021 16:11:45 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Jiasheng Jiang <jiasheng@...as.ac.cn>, davem@...emloft.net,
        colin.king@...el.com, netdev@...r.kernel.org
Subject: Re: [PATCH] drivers: net: smc911x: Fix wrong check for irq

On Fri, Dec 24, 2021 at 03:04:25PM -0800, Jakub Kicinski wrote:
> On Fri, 24 Dec 2021 13:12:54 +0800 Jiasheng Jiang wrote:
> > Because ndev->irq is unsigned
> 
> It's not..

https://elixir.bootlin.com/linux/v5.16-rc6/source/include/linux/netdevice.h#L2065

Definitely an int.

	   Andrew