netdev - Re: [PATCH net-next 1/1] qed: add prints if request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YchBy/UOM576Yv6d@lunn.ch>
Date:   Sun, 26 Dec 2021 11:19:55 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
Cc:     kuba@...nel.org, netdev@...r.kernel.org,
        Ariel Elior <aelior@...vell.com>,
        Alok Prasad <palok@...vell.com>
Subject: Re: [PATCH net-next 1/1] qed: add prints if request_firmware() failed

On Sat, Dec 25, 2021 at 04:14:08PM -0800, Venkata Sudheer Kumar Bhavaraju wrote:
> If driver load failed due to request_firmware() not finding the device
> firmware file, add prints that help remedy the situation.
> 
> Signed-off-by: Ariel Elior <aelior@...vell.com>
> Signed-off-by: Alok Prasad <palok@...vell.com>
> Signed-off-by: Venkata Sudheer Kumar Bhavaraju <vbhavaraju@...vell.com>
> ---
>  drivers/net/ethernet/qlogic/qed/qed_main.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ethernet/qlogic/qed/qed_main.c b/drivers/net/ethernet/qlogic/qed/qed_main.c
> index 46d4207f22a3..4f5d5a1e786c 100644
> --- a/drivers/net/ethernet/qlogic/qed/qed_main.c
> +++ b/drivers/net/ethernet/qlogic/qed/qed_main.c
> @@ -65,6 +65,9 @@ MODULE_LICENSE("GPL");
>  
>  MODULE_FIRMWARE(QED_FW_FILE_NAME);
>  
> +#define QED_FW_REPO		\
> +	"https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git"

linux-firmware is vendor/product neutral. So i would suggest dropping
the QED prefix. This URL is also used in a couple of other drivers, so
you could consider places it somewhere under include/linux/

    Andrew