netdev - Re: [PATCH] net: usb: pegasus: Do not drop long Ethernet frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 26 Dec 2021 17:31:45 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Matthias-Christian Ott <ott@...ix.org>
Cc:     Petko Manolov <petkan@...leusys.com>, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH] net: usb: pegasus: Do not drop long Ethernet frames

> > I've nothing against this patch, but if you are working on the driver,
> > it would be nice to replace these hex numbers with #defines using BIT,
> > or FIELD. It will make the code more readable.
> 
> Replacing the constants with macros is on my list of things that I want
> to do. In this case, I did not do it because I wanted to a have small
> patch that gets easily accepted and allows me to figure out the current
> process to submit patches after years of inactivity.

Agreed, keep fixes simple.

A few other hints. If you consider this a fix which should be back
ported, please add a Fixes: tag, where the issue started. This can be
back as far as the first commit for the driver. Fixes should also be
sent to the net tree, not net-next. See the netdev FAQ about the two
different trees.

	  Andrew