netdev - Re: [PATCH v2] asix: Use min() instead of doing it manually

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 27 Dec 2021 12:51:44 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
Cc:     davem@...emloft.net, kuba@...nel.org, linux-usb@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH v2] asix: Use min() instead of doing it manually

On Mon, Dec 27, 2021 at 07:38:39PM +0800, Jiapeng Chong wrote:
> Eliminate following coccicheck warning:
> 
> ./drivers/net/usb/asix_common.c:545:12-13: WARNING opportunity for
> min().
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---
> Changes in v2:
>   -Modified commmit message.
> 
>  drivers/net/usb/asix_common.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/usb/asix_common.c b/drivers/net/usb/asix_common.c
> index 71682970be58..da5a7df312d2 100644
> --- a/drivers/net/usb/asix_common.c
> +++ b/drivers/net/usb/asix_common.c
> @@ -542,7 +542,7 @@ static int __asix_mdio_write(struct net_device *netdev, int phy_id, int loc,
>  out:
>  	mutex_unlock(&dev->phy_mutex);
>  
> -	return ret < 0 ? ret : 0;
> +	return min(ret, 0);

This is not a good idea, as was already pointed out.  Please fix your
tools.

thanks,

greg k-h