netdev - Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQLd2y_Cuqrn+cAQzCjpXM_Lub5_X6xEfZdMMC2a2Jq41A@mail.gmail.com>
Date:   Wed, 29 Dec 2021 08:51:23 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Marc Kleine-Budde <mkl@...gutronix.de>, marcel@...tmann.org,
        johan.hedberg@...il.com, luiz.dentz@...il.com,
        Doug Ledford <dledford@...hat.com>,
        Jason Gunthorpe <jgg@...pe.ca>, mustafa.ismail@...el.com,
        shiraz.saleem@...el.com, Leon Romanovsky <leon@...nel.org>,
        Taehee Yoo <ap420073@...il.com>, wg@...ndegger.com,
        woojung.huh@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        vivien.didelot@...il.com, Florian Fainelli <f.fainelli@...il.com>,
        olteanv@...il.com, george.mccollister@...il.com,
        Michael Chan <michael.chan@...adcom.com>,
        Jesse Brandeburg <jesse.brandeburg@...el.com>,
        anthony.l.nguyen@...el.com,
        Jesper Dangaard Brouer <hawk@...nel.org>,
        John Fastabend <john.fastabend@...il.com>,
        Tariq Toukan <tariqt@...dia.com>, saeedm@...dia.com,
        ecree.xilinx@...il.com, habetsm.xilinx@...il.com, jreuter@...na.de,
        David Ahern <dsahern@...nel.org>, kvalo@...eaurora.org,
        pkshih@...ltek.com, trond.myklebust@...merspace.com,
        anna.schumaker@...app.com,
        Alexander Viro <viro@...iv.linux.org.uk>,
        Andrii Nakryiko <andrii@...nel.org>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Kees Cook <keescook@...omium.org>,
        Iurii Zaikin <yzaikin@...gle.com>, nikolay@...dia.com,
        jiri@...dia.com, wintera@...ux.ibm.com, wenjia@...ux.ibm.com,
        Pablo Neira Ayuso <pablo@...filter.org>,
        Jozsef Kadlecsik <kadlec@...filter.org>,
        Florian Westphal <fw@...len.de>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>, kgraul@...ux.ibm.com,
        sgarzare@...hat.com,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Arnd Bergmann <arnd@...db.de>, linux-bluetooth@...r.kernel.org,
        linux-rdma@...r.kernel.org, linux-can@...r.kernel.org,
        intel-wired-lan <intel-wired-lan@...ts.osuosl.org>,
        linux-hams@...r.kernel.org, ath11k@...ts.infradead.org,
        linux-wireless <linux-wireless@...r.kernel.org>,
        linux-nfs@...r.kernel.org,
        Linux-Fsdevel <linux-fsdevel@...r.kernel.org>,
        "moderated list:ETHERNET BRIDGE" <bridge@...ts.linux-foundation.org>,
        linux-decnet-user@...ts.sourceforge.net,
        linux-s390 <linux-s390@...r.kernel.org>,
        netfilter-devel <netfilter-devel@...r.kernel.org>,
        coreteam@...filter.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH bpf-next v2] net: don't include filter.h from net/sock.h

On Tue, Dec 28, 2021 at 4:49 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> sock.h is pretty heavily used (5k objects rebuilt on x86 after
> it's touched). We can drop the include of filter.h from it and
> add a forward declaration of struct sk_filter instead.
> This decreases the number of rebuilt objects when bpf.h
> is touched from ~5k to ~1k.
>
> There's a lot of missing includes this was masking. Primarily
> in networking tho, this time.
>
> Acked-by: Marc Kleine-Budde <mkl@...gutronix.de>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> v2: https://lore.kernel.org/all/20211228192519.386913-1-kuba@kernel.org/
>  - fix build in bond on ia64
>  - fix build in ip6_fib with randconfig

Nice! Applied. Thanks