netdev - Re: [PATCH v5] sun4i-emac.c: add dma support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211228164817.1297c1c9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 28 Dec 2021 16:48:17 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     conleylee@...mail.com
Cc:     davem@...emloft.net, mripard@...nel.org, wens@...e.org,
        netdev@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] sun4i-emac.c: add dma support

On Tue, 28 Dec 2021 19:42:04 +0800 conleylee@...mail.com wrote:
> +static void free_emac_dma_req(struct emac_dma_req *req)

emac_free_dma_req

> +prepare_err:
> +	dma_unmap_single(db->dev, rxbuf, count, DMA_FROM_DEVICE);
> +    return ret;

incorrect whitespace here

> @@ -599,12 +721,25 @@ static void emac_rx(struct net_device *dev)
>  			if (!skb)
>  				continue;
>  			skb_reserve(skb, 2);
> -			rdptr = skb_put(skb, rxlen - 4);
>  
>  			/* Read received packet from RX SRAM */
>  			if (netif_msg_rx_status(db))
>  				dev_dbg(db->dev, "RxLen %x\n", rxlen);
>  
> +			rdptr = skb_put(skb, rxlen - 4);

no reason to move this line