netdev - Re: [PATCH net-next 5/8] net/funeth: devlink support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211230094129.67507001@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 30 Dec 2021 09:41:29 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dimitris Michailidis <d.michailidis@...gible.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 5/8] net/funeth: devlink support

On Thu, 30 Dec 2021 08:39:06 -0800 Dimitris Michailidis wrote:
> +static int fun_dl_info_get(struct devlink *dl, struct devlink_info_req *req,
> +			   struct netlink_ext_ack *extack)
> +{
> +	int err;
> +
> +	err = devlink_info_driver_name_put(req, KBUILD_MODNAME);
> +	if (err)
> +		return err;
> +
> +	err = devlink_info_version_fixed_put(req,
> +			DEVLINK_INFO_VERSION_GENERIC_BOARD_MANUFACTURE,
> +			"Fungible");

Manufacture is a factory. This field is for reporting which contractor
produced the physical board. I doubt Fungible does its own assembly.

> +	if (err)
> +		return err;
> +
> +	return 0;
> +}
> +
> +static const struct devlink_ops fun_dl_ops = {
> +	.info_get       = fun_dl_info_get,
> +	.flash_update   = fun_dl_flash_update,
> +};

There's init clearly missing here. Please go back and make sure 
all the functionality actually works upstream.