netdev - Re: [PATCH net-next 3/8] net/funeth: probing and netdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOkoqZ=ba_QiOdKbN==LU7gKCNSSfAbq29UJBPKB8MvX5sMJPQ@mail.gmail.com>
Date:   Thu, 30 Dec 2021 10:33:03 -0800
From:   Dimitris Michailidis <d.michailidis@...gible.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/8] net/funeth: probing and netdev ops

On Thu, Dec 30, 2021 at 9:40 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> > +static int msg_enable;
> > +module_param(msg_enable, int, 0644);
> > +MODULE_PARM_DESC(msg_enable, "bitmap of NETIF_MSG_* enables");
> > +
>
> Module params are not liked. Please implement the ethtool op, if you
> have not already done so.

The associated ethtool op is implemented. I think this module param is
fairly common
to control messages during probe and generally before the ethtool path
is available.

>
>      Andrew