netdev - Re: [PATCH net-next 3/8] net/funeth: probing and netdev ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOkoqZn-1fz24M089gnK1bbuVBgmv9YKCSiRZm7OEwgrkD3UNw@mail.gmail.com>
Date:   Thu, 30 Dec 2021 12:05:05 -0800
From:   Dimitris Michailidis <d.michailidis@...gible.com>
To:     Andrew Lunn <andrew@...n.ch>
Cc:     davem@...emloft.net, kuba@...nel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 3/8] net/funeth: probing and netdev ops

On Thu, Dec 30, 2021 at 11:02 AM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Thu, Dec 30, 2021 at 10:33:03AM -0800, Dimitris Michailidis wrote:
> > On Thu, Dec 30, 2021 at 9:40 AM Andrew Lunn <andrew@...n.ch> wrote:
> > >
> > > > +static int msg_enable;
> > > > +module_param(msg_enable, int, 0644);
> > > > +MODULE_PARM_DESC(msg_enable, "bitmap of NETIF_MSG_* enables");
> > > > +
> > >
> > > Module params are not liked. Please implement the ethtool op, if you
> > > have not already done so.
> >
> > The associated ethtool op is implemented. I think this module param is
> > fairly common
> > to control messages during probe and generally before the ethtool path
> > is available.
>
> It is common in order drivers, but in general new drivers don't have
> module parameters at all. Anybody debugging code before ethtool is
> available from user space is probably also capable of recompiling the
> driver to change the default value.

OK, will remove it.

>        Andrew