netdev - Re: [PATCH net-next 4/8] net/funeth: ethtool operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211230122227.6ca6bfb7@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Thu, 30 Dec 2021 12:22:27 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dimitris Michailidis <d.michailidis@...gible.com>
Cc:     Andrew Lunn <andrew@...n.ch>, davem@...emloft.net,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next 4/8] net/funeth: ethtool operations

On Thu, 30 Dec 2021 19:04:08 +0100 Andrew Lunn wrote:
> > +static void fun_get_drvinfo(struct net_device *netdev,
> > +			    struct ethtool_drvinfo *info)
> > +{
> > +	const struct funeth_priv *fp = netdev_priv(netdev);
> > +
> > +	strscpy(info->driver, KBUILD_MODNAME, sizeof(info->driver));
> > +	strcpy(info->fw_version, "N/A");  
> 
> Don't set it, if you have nothing useful to put in it.

Also, if user has no way of reading the firmware version how do they
know when to update the FW in the flash? FW flashing seems pointless
without knowing the current FW version.