netdev - Re: [PATCH net-next 8/8] net/fungible: Kconfig, Makefiles, and MAINTAINERS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOkoqZny2=S-+sApOn7pKroYoB8HVS3XCCFRmB5DB7k3B0THjA@mail.gmail.com>
Date:   Thu, 30 Dec 2021 13:16:16 -0800
From:   Dimitris Michailidis <d.michailidis@...gible.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 8/8] net/fungible: Kconfig, Makefiles, and MAINTAINERS

On Thu, Dec 30, 2021 at 12:54 PM Dimitris Michailidis
<d.michailidis@...gible.com> wrote:
>
> On Thu, Dec 30, 2021 at 9:43 AM Jakub Kicinski <kuba@...nel.org> wrote:
> >
> > On Thu, 30 Dec 2021 08:39:09 -0800 Dimitris Michailidis wrote:
> > > Hook up the new driver to configuration and build.
> > >
> > > Signed-off-by: Dimitris Michailidis <dmichail@...gible.com>
> >
> > New drivers must build cleanly with W=1 C=1. This one doesn't build at all:
> >
> > drivers/net/ethernet/fungible/funeth/funeth.h:10:10: fatal error: fun_dev.h: No such file or directory
> >    10 | #include "fun_dev.h"
> >       |          ^~~~~~~~~~~
>
> Hmm, I don't get this error. What I run is
>
> make W=1 C=1 drivers/net/ethernet/fungible/
>
> and it goes through. Tried it also on net-next as of a few minutes ago.
> Any ideas what may be different?

Never mind, I see what happened. One of the patches is bad and is not
adding the paths correctly.

Do let me know if I should address the header 'static const' warnings
from -Wunused-const-variable.

>
> I do get a number of warnings because there are constants in one of
> the headers defined
> as 'static const' and they get flagged when a .c doesn't use them.
> This looks like a tool
> shortcoming to me. Do you want me to try to redo them as defines or enum?