netdev - Re: [PATCH] selftests/net: udpgso_bench

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211229182514.54892af9@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Wed, 29 Dec 2021 18:25:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Willem de Bruijn <willemdebruijn.kernel@...il.com>,
        Jianguo Wu <wujianguo106@....com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH] selftests/net: udpgso_bench_tx: fix dst ip argument

On Wed, 29 Dec 2021 09:16:37 -0500 Willem de Bruijn wrote:
> On Wed, Dec 29, 2021 at 5:58 AM Jianguo Wu <wujianguo106@....com> wrote:
> >
> > From: wujianguo <wujianguo@...natelecom.cn>
> >
> > udpgso_bench_tx call setup_sockaddr() for dest address before
> > parsing all arguments, if we specify "-p ${dst_port}" after "-D ${dst_ip}",
> > then ${dst_port} will be ignored, and using default cfg_port 8000.
> >
> > This will cause test case "multiple GRO socks" failed in udpgro.sh.
> >
> > Setup sockaddr after after parsing all arguments.

s/after after/after/

> >
> > Fixes: 3a687bef148d ("selftests: udp gso benchmark")
> > Signed-off-by: Jianguo Wu <wujianguo@...natelecom.cn>  
> 
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
> 
> The udpgso_bench_tx equivalent to commit d336509cb9d0 ("selftests/net:
> udpgso_bench_rx: fix port argument"). Thanks.

Applied, thanks!