netdev - [Resource Leak] Missing closing files in samples/bpf/hbm.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <BCA4C02F-0238-4818-BDF1-2F0411CD95A6@gmail.com>
Date:   Thu, 30 Dec 2021 11:26:31 +0800
From:   Ryan Cai <ycaibb@...il.com>
To:     <ast@...nel.org>, <daniel@...earbox.net>, <andrii@...nel.org>,
        <kafai@...com>, <songliubraving@...com>, <yhs@...com>,
        <john.fastabend@...il.com>, <kpsingh@...nel.org>
CC:     <netdev@...r.kernel.org>, <bpf@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [Resource Leak] Missing closing files in samples/bpf/hbm.c

Dear Kernel maintainers,

          1. In run_bpf_prog, the file opened at Line 308 may not closed when going to Line 310.
          Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/samples/bpf/hbm.c#L302-L310

         2. In read_trace_pipe2, the file opened at Line 91 may not closed in the function.
         Location: https://github.com/torvalds/linux/blob/5bfc75d92efd494db37f5c4c173d3639d4772966/samples/bpf/hbm.c#L91-L109

           Should it be a bug? I can send a patch for these.

Best,
Ryan