netdev - Re: [PATCH] net/smc: remove redundant re-assignment of pointer link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 31 Dec 2021 14:00:39 +0800
From:   Tony Lu <tonylu@...ux.alibaba.com>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Karsten Graul <kgraul@...ux.ibm.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, linux-s390@...r.kernel.org,
        netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net/smc: remove redundant re-assignment of pointer link

On Thu, Dec 30, 2021 at 03:39:00PM +0000, Colin Ian King wrote:
> The pointer link is being re-assigned the same value that it was
> initialized with in the previous declaration statement. The
> re-assignment is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

It would be better to add Fixes statement in the end of message.

  Fixes: 387707fdf486 ("net/smc: convert static link ID to dynamic references")

And [PATCH net ...] is fine to point out the target. The patch itself
looks good to me, thanks.

Reviewed-by: Tony Lu <tonylu@...ux.alibaba.com>

Thanks,
Tony Lu