netdev - Re: [PATCH net-next 00/10] net: hns3: refactor cmdq functions in PF/VF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 31 Dec 2021 18:22:54 +0800
From:   "huangguangbin (A)" <huangguangbin2@...wei.com>
To:     <davem@...emloft.net>, <kuba@...nel.org>, <wangjie125@...wei.com>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <lipeng321@...wei.com>, <chenhao288@...ilicon.com>
Subject: Re: [PATCH net-next 00/10] net: hns3: refactor cmdq functions in
 PF/VF

I am sorry, this patch-set is incomplete, please ignore this series.

On 2021/12/31 18:14, Guangbin Huang wrote:
> Currently, hns3 PF and VF module have two sets of cmdq APIs to provide
> cmdq message interaction functions. Most of these APIs are the same. The
> only differences are the function variables and names with pf and vf
> suffixes. These two sets of cmdq APIs are redundent and add extra bug fix
> work.
> 
> This series refactor the cmdq APIs in hns3 PF and VF by implementing one
> set of common cmdq APIs for PF and VF reuse and deleting the old APIs.
> 
> Jie Wang (10):
>    net: hns3: create new set of unified hclge_comm_cmd_send APIs
>    net: hns3: refactor hclge_cmd_send with new hclge_comm_cmd_send API
>    net: hns3: refactor hclgevf_cmd_send with new hclge_comm_cmd_send API
>    net: hns3: create common cmdq resource allocate/free/query APIs
>    net: hns3: refactor PF cmdq resource APIs with new common APIs
>    net: hns3: refactor VF cmdq resource APIs with new common APIs
>    net: hns3: create common cmdq init and uninit APIs
>    net: hns3: refactor PF cmdq init and uninit APIs with new common APIs
>    net: hns3: refactor VF cmdq init and uninit APIs with new common APIs
>    net: hns3: delete the hclge_cmd.c and hclgevf_cmd.c
> 
>   drivers/net/ethernet/hisilicon/hns3/Makefile  |   9 +-
>   .../hns3/hns3_common/hclge_comm_cmd.c         | 626 ++++++++++++++++++
>   .../hns3/hns3_common/hclge_comm_cmd.h         | 172 +++++
>   .../hisilicon/hns3/hns3pf/hclge_cmd.c         | 591 -----------------
>   .../hisilicon/hns3/hns3pf/hclge_cmd.h         | 153 +----
>   .../hisilicon/hns3/hns3pf/hclge_debugfs.c     |  10 +-
>   .../hisilicon/hns3/hns3pf/hclge_err.c         |  25 +-
>   .../hisilicon/hns3/hns3pf/hclge_main.c        | 170 ++---
>   .../hisilicon/hns3/hns3pf/hclge_main.h        |  23 +-
>   .../hisilicon/hns3/hns3pf/hclge_mbx.c         |  16 +-
>   .../hisilicon/hns3/hns3pf/hclge_mdio.c        |   4 +-
>   .../hisilicon/hns3/hns3pf/hclge_ptp.c         |   2 +-
>   .../hisilicon/hns3/hns3vf/hclgevf_cmd.c       | 556 ----------------
>   .../hisilicon/hns3/hns3vf/hclgevf_cmd.h       | 140 +---
>   .../hisilicon/hns3/hns3vf/hclgevf_main.c      | 133 ++--
>   .../hisilicon/hns3/hns3vf/hclgevf_main.h      |  30 +-
>   .../hisilicon/hns3/hns3vf/hclgevf_mbx.c       |  19 +-
>   17 files changed, 1046 insertions(+), 1633 deletions(-)
>   create mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3_common/hclge_comm_cmd.c
>   delete mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_cmd.c
>   delete mode 100644 drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_cmd.c
>