netdev - Re: [PATCH v5 net-next 1/3] seg6: export get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 3 Jan 2022 15:52:36 -0500
From:   Willem de Bruijn <willemdebruijn.kernel@...il.com>
To:     David Ahern <dsahern@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Hideaki YOSHIFUJI <yoshfuji@...ux-ipv6.org>,
        David Ahern <dsahern@...nel.org>,
        James Prestwood <prestwoj@...il.com>,
        Justin Iurman <justin.iurman@...ege.be>,
        Praveen Chaudhary <praveen5582@...il.com>,
        "Jason A . Donenfeld" <Jason@...c4.com>,
        Eric Dumazet <edumazet@...gle.com>,
        netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH v5 net-next 1/3] seg6: export get_srh() for ICMP handling

On Mon, Jan 3, 2022 at 12:31 PM David Ahern <dsahern@...il.com> wrote:
>
> On 1/3/22 10:11 AM, Andrew Lunn wrote:
> > An ICMP error message can contain in its message body part of an IPv6
> > packet which invoked the error. Such a packet might contain a segment
> > router header. Export get_srh() so the ICMP code can make use of it.
> >
> > Since his changes the scope of the function from local to global, add
> > the seg6_ prefix to keep the namespace clean. And move it into seg6.c
> > so it is always available, not just when IPV6_SEG6_LWTUNNEL is
> > enabled.
> >
> > Signed-off-by: Andrew Lunn <andrew@...n.ch>
> > ---
> >  include/net/seg6.h    |  1 +
> >  net/ipv6/seg6.c       | 29 +++++++++++++++++++++++++++++
> >  net/ipv6/seg6_local.c | 33 ++-------------------------------
> >  3 files changed, 32 insertions(+), 31 deletions(-)
> >
>
> Reviewed-by: David Ahern <dsahern@...nel.org>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>