lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAB_54W7jpTJ-PicyZLTvY4+ELdQVgELR1wRPrSjbZOBLzz46Jg@mail.gmail.com> Date: Mon, 3 Jan 2022 10:27:12 -0500 From: Alexander Aring <alex.aring@...il.com> To: Pavel Skripkin <paskripkin@...il.com> Cc: Stefan Schmidt <stefan@...enfreihafen.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, linux-wpan - ML <linux-wpan@...r.kernel.org>, "open list:NETWORKING [GENERAL]" <netdev@...r.kernel.org>, kernel list <linux-kernel@...r.kernel.org>, Alexander Potapenko <glider@...gle.com> Subject: Re: [PATCH v2] ieee802154: atusb: fix uninit value in atusb_set_extended_addr Hi, On Mon, 3 Jan 2022 at 07:09, Pavel Skripkin <paskripkin@...il.com> wrote: > > Alexander reported a use of uninitialized value in > atusb_set_extended_addr(), that is caused by reading 0 bytes via > usb_control_msg(). > > Fix it by validating if the number of bytes transferred is actually > correct, since usb_control_msg() may read less bytes, than was requested > by caller. > > Fail log: > > BUG: KASAN: uninit-cmp in ieee802154_is_valid_extended_unicast_addr include/linux/ieee802154.h:310 [inline] > BUG: KASAN: uninit-cmp in atusb_set_extended_addr drivers/net/ieee802154/atusb.c:1000 [inline] > BUG: KASAN: uninit-cmp in atusb_probe.cold+0x29f/0x14db drivers/net/ieee802154/atusb.c:1056 > Uninit value used in comparison: 311daa649a2003bd stack handle: 000000009a2003bd > ieee802154_is_valid_extended_unicast_addr include/linux/ieee802154.h:310 [inline] > atusb_set_extended_addr drivers/net/ieee802154/atusb.c:1000 [inline] > atusb_probe.cold+0x29f/0x14db drivers/net/ieee802154/atusb.c:1056 > usb_probe_interface+0x314/0x7f0 drivers/usb/core/driver.c:396 > > Fixes: 7490b008d123 ("ieee802154: add support for atusb transceiver") > Reported-by: Alexander Potapenko <glider@...gle.com> > Signed-off-by: Pavel Skripkin <paskripkin@...il.com> Acked-by: Alexander Aring <aahringo@...hat.com> Although I think if such error exists the most common solution would be to replug the usb device and hope it gets resolved? A retry with a maximum amount would be another try... However, let's hope those errors are rare and we care about them when they occur. Thanks. - Alex
Powered by blists - more mailing lists