lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <46c09b62-d50f-fd2e-3eb4-ed4b643eef4a@marcan.st> Date: Mon, 3 Jan 2022 14:51:53 +0900 From: Hector Martin <marcan@...can.st> To: Linus Walleij <linus.walleij@...aro.org> Cc: Kalle Valo <kvalo@...eaurora.org>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Rob Herring <robh+dt@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, Arend van Spriel <aspriel@...il.com>, Franky Lin <franky.lin@...adcom.com>, Hante Meuleman <hante.meuleman@...adcom.com>, Chi-hsien Lin <chi-hsien.lin@...ineon.com>, Wright Feng <wright.feng@...ineon.com>, Sven Peter <sven@...npeter.dev>, Alyssa Rosenzweig <alyssa@...enzweig.io>, Mark Kettenis <kettenis@...nbsd.org>, Rafał Miłecki <zajec5@...il.com>, Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>, Hans de Goede <hdegoede@...hat.com>, "John W. Linville" <linville@...driver.com>, "brian m. carlson" <sandals@...stytoothpaste.net>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, brcm80211-dev-list.pdl@...adcom.com, SHA-cyfmac-dev-list@...ineon.com Subject: Re: [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information On 2022/01/02 14:38, Linus Walleij wrote: > On Sun, Dec 26, 2021 at 4:37 PM Hector Martin <marcan@...can.st> wrote: > >> On Apple platforms, the One Time Programmable ROM in the Broadcom chips >> contains information about the specific board design (module, vendor, >> version) that is required to select the correct NVRAM file. Parse this >> OTP ROM and extract the required strings. >> >> Note that the user OTP offset/size is per-chip. This patch does not add >> any chips yet. >> >> Signed-off-by: Hector Martin <marcan@...can.st> > > Overall looks fine! > >> + const char *chip_params; >> + const char *module_params; > > This variable name "module_params" is a bit confusing since loadable > kernel modules have params... > > Can we think of another name and just put a comment that this > refers to the WiFi module building block? > > Sometimes people talk about SoM:s (system-on-modules), so > maybe som_params or brcm_som_params? > > Yours, > Linus Walleij > How about board_params, since we're already calling those things boards elsewhere in the driver? That could refer to the board of a standalone module, or an integrated board, which should cover all cases. -- Hector Martin (marcan@...can.st) Public Key: https://mrcn.st/pub
Powered by blists - more mailing lists