netdev - Re: [PATCH net-next] net: fixup build after bpf header changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 4 Jan 2022 13:24:07 +0530
From:   Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
To:     Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc:     netdev@...r.kernel.org, jesse.brandeburg@...el.com,
        anthony.l.nguyen@...el.com, saeedm@...dia.com, leon@...nel.org,
        intel-wired-lan@...ts.osuosl.org, linux-rdma@...r.kernel.org,
        bpf@...r.kernel.org, sachinp <sachinp@...ux.vnet.ibm.com>,
        Brian King <brking@...ux.vnet.ibm.com>
Subject: Re: [PATCH net-next] net: fixup build after bpf header changes

Hi

Thank You Jakub for the patch.

Kernel builds fine with given patch fix

Tested-by : Abdul haleem <abdhalee@...ux.vnet.ibm.com>

On 1/4/22 9:18 AM, Jakub Kicinski wrote:

> Recent bpf-next merge brought in header changes which uncovered
> includes missing in net-next which were not present in bpf-next.
> Build problems happen only on less-popular arches like hppa,
> sparc, alpha etc.
>
> I could repro the build problem with ice but not the mlx5 problem
> Abdul was reporting. mlx5 does look like it should include filter.h,
> anyway.
>
> Reported-by: Abdul Haleem <abdhalee@...ux.vnet.ibm.com>
> Fixes: e63a02348958 ("Merge git://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next")
> Link: https://lore.kernel.org/all/7c03768d-d948-c935-a7ab-b1f963ac7eed@linux.vnet.ibm.com/
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> CC: jesse.brandeburg@...el.com
> CC: anthony.l.nguyen@...el.com
> CC: saeedm@...dia.com
> CC: leon@...nel.org
> CC: intel-wired-lan@...ts.osuosl.org
> CC: linux-rdma@...r.kernel.org
> CC: bpf@...r.kernel.org
> ---
>   drivers/net/ethernet/intel/ice/ice_nvm.c          | 2 ++
>   drivers/net/ethernet/mellanox/mlx5/core/en_main.c | 1 +
>   2 files changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c b/drivers/net/ethernet/intel/ice/ice_nvm.c
> index cd739a2c64e8..4eb0599714f4 100644
> --- a/drivers/net/ethernet/intel/ice/ice_nvm.c
> +++ b/drivers/net/ethernet/intel/ice/ice_nvm.c
> @@ -1,6 +1,8 @@
>   // SPDX-License-Identifier: GPL-2.0
>   /* Copyright (c) 2018, Intel Corporation. */
>
> +#include <linux/vmalloc.h>
> +
>   #include "ice_common.h"
>
>   /**
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> index efcf9d30b131..31c911182498 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_main.c
> @@ -37,6 +37,7 @@
>   #include <net/geneve.h>
>   #include <linux/bpf.h>
>   #include <linux/if_bridge.h>
> +#include <linux/filter.h>
>   #include <net/page_pool.h>
>   #include <net/xdp_sock_drv.h>
>   #include "eswitch.h"

-- 
Regard's

Abdul Haleem
IBM Linux Technology Center