netdev - RE: [PATCH CFT net-next 1/2] net: axienet: convert to phylink

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BL3PR02MB8187165DAF278F65C8024567C94A9@BL3PR02MB8187.namprd02.prod.outlook.com>
Date:   Tue, 4 Jan 2022 09:12:06 +0000
From:   Harini Katakam <harinik@...inx.com>
To:     Russell King <linux@...linux.org.uk>
CC:     Jakub Kicinski <kuba@...nel.org>,
        Michal Simek <michals@...inx.com>,
        Radhey Shyam Pandey <radheys@...inx.com>,
        Sean Anderson <sean.anderson@...o.com>,
        "David S. Miller" <davem@...emloft.net>,
        netdev <netdev@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs



> -----Original Message-----
> From: Russell King <linux@...linux.org.uk>
> Sent: Tuesday, January 4, 2022 2:31 PM
> To: Harini Katakam <harinik@...inx.com>
> Cc: Jakub Kicinski <kuba@...nel.org>; Michal Simek <michals@...inx.com>;
> Radhey Shyam Pandey <radheys@...inx.com>; Sean Anderson
> <sean.anderson@...o.com>; David S. Miller <davem@...emloft.net>;
> netdev <netdev@...r.kernel.org>; linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH CFT net-next 1/2] net: axienet: convert to phylink_pcs
> 
> On Tue, Jan 04, 2022 at 01:26:28PM +0530, Harini Katakam wrote:
> > On Fri, Dec 17, 2021 at 1:55 PM Harini Katakam <harinik@...inx.com> wrote:
> > >
> > > Hi Russell,
> > >
> > > On Fri, Dec 17, 2021 at 5:26 AM Russell King (Oracle)
> > > <linux@...linux.org.uk> wrote:
> > > >
> > > > On Thu, Dec 16, 2021 at 07:15:13AM -0800, Jakub Kicinski wrote:
> > > > > On Thu, 16 Dec 2021 12:48:45 +0000 Russell King (Oracle) wrote:
> > > > > > Convert axienet to use the phylink_pcs layer, resulting in it
> > > > > > no longer being a legacy driver.
> > > > > >
> > > > > > One oddity in this driver is that lp->switch_x_sgmii controls
> > > > > > whether we support switching between SGMII and 1000baseX.
> > > > > > However, when clear, this also blocks updating the 1000baseX
> > > > > > advertisement, which it probably should not be doing.
> > > > > > Nevertheless, this behaviour is preserved but a comment is added.
> > > > > >
> > > > > > Signed-off-by: Russell King (Oracle)
> > > > > > <rmk+kernel@...linux.org.uk>
> > > > >
> > > > > drivers/net/ethernet/xilinx/xilinx_axienet.h:479: warning: Function
> parameter or member 'pcs' not described in 'axienet_local'
> > > >
> > > > Fixed that and the sha1 issue you raised in patch 2. Since both
> > > > are "documentation" issues, I won't send out replacement patches
> > > > until I've heard they've been tested on hardware though.
> > >
> > > Thanks for the patches.
> > > Series looks good and we're testing at our end; will get back to you
> > > early next week.
> >
> > Thanks Russell. I've tested AXI Ethernet and it works fine.
> 
> Happy new year!
> 
> Thanks - can I use that as a tested-by please, and would you be happy for me
> to send the patches for merging this week?

Sure, yes and yes.
Tested-by: Harini Katakam <harini.katakam@...inx.com>

Happy new year to you too!

Regards,
Harini