[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <68e62015-9cba-f29e-b75a-d16561f446e5@linux.alibaba.com>
Date: Tue, 4 Jan 2022 21:04:35 +0800
From: "D. Wythe" <alibuda@...ux.alibaba.com>
To: Tony Lu <tonylu@...ux.alibaba.com>
Cc: kgraul@...ux.ibm.com, kuba@...nel.org, davem@...emloft.net,
netdev@...r.kernel.org, linux-s390@...r.kernel.org,
linux-rdma@...r.kernel.org
Subject: Re: [PATCH net-next] net/smc: Reduce overflow of smc clcsock listen
queue
Got it, i'll fix it soon.
Thanks.
在 2022/1/4 下午9:01, Tony Lu 写道:
> On Tue, Jan 04, 2022 at 06:58:50PM +0800, D. Wythe wrote:
>> From: "D. Wythe" <alibuda@...ux.alibaba.com>
>>
>> In nginx/wrk multithread and 10K connections benchmark, the
>> backend TCP connection established very slowly, and lots of TCP
>> connections stay in SYN_SENT state.
> <snip>
>
>> +struct workqueue_struct *smc_tcp_ls_wq; /* wq for tcp listen work*/
> missing a space here ^
>> struct workqueue_struct *smc_hs_wq; /* wq for handshake work */
>> struct workqueue_struct *smc_close_wq; /* wq for close work */
> <snip>
>
>> return (struct smc_sock *)sk;
>> }
>>
>> +extern struct workqueue_struct *smc_tcp_ls_wq; /* wq for tcp listen work*/
> missing a space here ^
>
> There are missing two spaces in comments. Besides that, this patch looks
> good to me, thanks.
>
> Reviewed-by: Tony Lu <tonylu@...ux.alibaba.com>
>
> Thanks.
> Tony Lu
Powered by blists - more mailing lists