netdev - Re: [PATCH net-next v5] rtnetlink: Support fine-grained netdevice bulk deletion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220104065548.3845f255@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
Date:   Tue, 4 Jan 2022 06:55:48 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Lahav Schlesinger <lschlesinger@...venets.com>
Cc:     David Ahern <dsahern@...il.com>, netdev@...r.kernel.org,
        nikolay@...dia.com
Subject: Re: [PATCH net-next v5] rtnetlink: Support fine-grained netdevice
 bulk deletion

On Tue, 4 Jan 2022 10:21:21 +0200 Lahav Schlesinger wrote:
> Hi Jakub, I just sent a V6 for this patch. Just wanted to note that I
> tried this approach of using unreg_list, but it caused issues with e.g.
> veth deletion - the dellink() of a veth peer automatically adds the
> other peer to the queued list. So if the list of ifindices contains
> both peers then when 'to_kill' is iterated, both the current device
> and the next pointer will have their 'unreg_list' moved to the other
> list, which later raised a page fault when 'to_kill' was further
> iterated upon.
> 
> Therefore instead I added a big flag in a "hole" inside struct
> net_device, as David suggested.

Ack. Thanks for trying it out.