netdev - Re: [PATCH net-next 11/13] netlink: add net device refcount tracker to struct ethnl_req

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5836510f3ea87678e1a3bf6d9ff09c0e70942d13.camel@sipsolutions.net>
Date:   Tue, 04 Jan 2022 16:29:23 +0100
From:   Johannes Berg <johannes@...solutions.net>
To:     Eric Dumazet <eric.dumazet@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Cc:     netdev <netdev@...r.kernel.org>, Eric Dumazet <edumazet@...gle.com>
Subject: Re: [PATCH net-next 11/13] netlink: add net device refcount tracker
 to struct ethnl_req_info

On Mon, 2021-12-06 at 17:30 -0800, Eric Dumazet wrote:
> 
> @@ -624,6 +625,7 @@ static void ethnl_default_notify(struct net_device *dev, unsigned int cmd,
>  	}
>  
>  	req_info->dev = dev;
> +	netdev_tracker_alloc(dev, &req_info->dev_tracker, GFP_KERNEL);
>  	req_info->flags |= ETHTOOL_FLAG_COMPACT_BITSETS;
> 

I may have missed a follow-up patch (did a search on netdev now, but
...), but I'm hitting warnings from this and I'm not sure it's right?

This req_info is just allocated briefly and freed again, and I'm not
even sure there's a dev_get/dev_put involved here, I didn't see any?

At least it would seem we need to free the tracker at the end of this
function, or perhaps never even create one?

johannes