netdev - Re: [PATCH net 1/2] net: bridge: mcast: add and enforce query interval minimum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <425e92d0-4321-8f9d-fc75-bba29f172550@gmail.com>
Date:   Wed, 5 Jan 2022 10:14:37 -0800
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Nikolay Aleksandrov <nikolay@...dia.com>, netdev@...r.kernel.org
Cc:     eric.dumazet@...il.com, stable@...r.kernel.org,
        herbert@...dor.apana.org.au, roopa@...dia.com, davem@...emloft.net,
        bridge@...ts.linux-foundation.org, kuba@...nel.org
Subject: Re: [PATCH net 1/2] net: bridge: mcast: add and enforce query
 interval minimum


On 12/27/21 09:21, Nikolay Aleksandrov wrote:
> As reported[1] if query interval is set too low and we have multiple
> bridges or even a single bridge with multiple querier vlans configured
> we can crash the machine. Add a 1 second minimum which must be enforced
> by overwriting the value if set lower (i.e. without returning an error) to
> avoid breaking user-space. If that happens a log message is emitted to let
> the administrator know that the interval has been set to the minimum.
> The issue has been present since these intervals could be user-controlled.
>
> [1] https://lore.kernel.org/netdev/e8b9ce41-57b9-b6e2-a46a-ff9c791cf0ba@gmail.com/
>
> Fixes: d902eee43f19 ("bridge: Add multicast count/interval sysfs entries")
> Reported-by: Eric Dumazet <eric.dumazet@...il.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@...dia.com>
> ---


Reviewed-by: Eric Dumazet <edumazet@...gle.com>

Thanks !