netdev - Re: [PATCH bpf-next] bpf, sockmap: fix double bpf_prog_put on error case in map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <164141220975.28548.12480548960134714730.git-patchwork-notify@kernel.org>
Date:   Wed, 05 Jan 2022 19:50:09 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     John Fastabend <john.fastabend@...il.com>
Cc:     ast@...nel.org, daniel@...earbox.net, netdev@...r.kernel.org,
        bpf@...r.kernel.org, joamaki@...il.com
Subject: Re: [PATCH bpf-next] bpf,
 sockmap: fix double bpf_prog_put on error case in map_link

Hello:

This patch was applied to bpf/bpf-next.git (master)
by Daniel Borkmann <daniel@...earbox.net>:

On Tue,  4 Jan 2022 13:46:45 -0800 you wrote:
> sock_map_link() is called to update a sockmap entry with a sk. But, if the
> sock_map_init_proto() call fails then we return an error to the map_update
> op against the sockmap. In the error path though we need to cleanup psock
> and dec the refcnt on any programs associated with the map, because we
> refcnt them early in the update process to ensure they are pinned for the
> psock. (This avoids a race where user deletes programs while also updating
> the map with new socks.)
> 
> [...]

Here is the summary with links:
  - [bpf-next] bpf, sockmap: fix double bpf_prog_put on error case in map_link
    https://git.kernel.org/bpf/bpf-next/c/218d747a4142

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html