netdev - Re: [PATCH -next] ieee802154: atusb: move to new USB API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8da136c2-a4f8-bc3b-7c61-de29217153fa@gmail.com>
Date:   Wed, 5 Jan 2022 23:58:03 +0300
From:   Pavel Skripkin <paskripkin@...il.com>
To:     Stefan Schmidt <stefan@...enfreihafen.org>, alex.aring@...il.com,
        davem@...emloft.net, kuba@...nel.org, linux-wpan@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] ieee802154: atusb: move to new USB API

Hi Stefan,

On 1/5/22 23:27, Stefan Schmidt wrote:
>> +	ret = usb_control_msg_recv(usb_dev, 0, ATUSB_REG_READ, ATUSB_REQ_FROM_DEV,
>> +				   0, RG_PART_NUM, &atusb, 1, 1000, GFP_KERNEL);
> 
> This needs to be written to &part_num and not &atusb.
> 

Oh, stupid copy-paste error :( Thanks for catching this!

> Pretty nice for a first blind try without hardware. Thanks.
> 
> Will let you know if I find anything else from testing.

Ok, will wait for test results. Thank you for your time ;)


With regards,
Pavel Skripkin