netdev - Re: [PATCH net v4] net/smc: Reset conn->lgr when link group registration fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <998065f4-eb0e-3799-4bdb-345daf2d963d@linux.alibaba.com>
Date:   Thu, 6 Jan 2022 19:33:41 +0800
From:   Wen Gu <guwen@...ux.alibaba.com>
To:     Karsten Graul <kgraul@...ux.ibm.com>, davem@...emloft.net,
        kuba@...nel.org
Cc:     linux-s390@...r.kernel.org, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v4] net/smc: Reset conn->lgr when link group
 registration fails



On 2022/1/6 6:00 pm, Karsten Graul wrote:

> Looks like I missed a prereq patch here, but wo'nt conn->lgr be set to NULL
> after smc_conn_free() called smc_lgr_unregister_conn()?

Right... I should hold a local copy of lgr in smc_conn_abort().

My another RFC patch removes 'conn->lgr = NULL' from smc_lgr_unregister_conn(),
so I make a mistake here...

I will fix this. Thank you.

Wen Gu