netdev - Re: [PATCH net-next v4 2/8] net/fungible: Add service module for Fungible drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOkoqZmWeNRyEP2HvN6=ZOyNhXroZ+eYSNAmjFN0gPjKAEw0ow@mail.gmail.com>
Date:   Wed, 5 Jan 2022 16:57:11 -0800
From:   Dimitris Michailidis <d.michailidis@...gible.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>
Subject: Re: [PATCH net-next v4 2/8] net/fungible: Add service module for
 Fungible drivers

On Wed, Jan 5, 2022 at 9:33 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 4 Jan 2022 22:12:35 -0800 Dimitris Michailidis wrote:
> > On Tue, Jan 4, 2022 at 8:49 PM Dimitris Michailidis
> > > On Tue, Jan 4, 2022 at 6:10 PM Jakub Kicinski <kuba@...nel.org> wrote:
> > > > CHECK: Unnecessary parentheses around 'fdev->admin_q->rq_depth > 0'
> > > > #630: FILE: drivers/net/ethernet/fungible/funcore/fun_dev.c:584:
> > > > +       if (cq_count < 2 || sq_count < 2 + (fdev->admin_q->rq_depth > 0))
> > >
> > > I saw this one but checkpatch misunderstands this expression.
> > > There are different equivalent expressions that wouldn't have them
> > > but this one needs them.
> >
> > What I wrote is probably unclear. By 'them' I meant the parentheses.
>
> I see, perhaps it's better written as:
>
>         if (cq_count < 2 || sq_count < 2 + !!fdev->admin_q->rq_depth)

That's the "different equivalent expression" I alluded to. I won't
call it better
but I'll appease checkpatch.