netdev - Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CANn89iKaekDBCzPMeoKsnyWSfQof5ZXMzR568XrgA2aC8Joexg@mail.gmail.com>
Date:   Thu, 6 Jan 2022 09:23:38 -0800
From:   Eric Dumazet <edumazet@...gle.com>
To:     "Benjamin.Yim" <yan2228598786@...il.com>
Cc:     kuba@...nel.org, davem@...emloft.net, yoshfuji@...ux-ipv6.org,
        dsahern@...nel.org, ast@...nel.org, daniel@...earbox.net,
        andrii@...nel.org, kafai@...com, songliubraving@...com, yhs@...com,
        john.fastabend@...il.com, kpsingh@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH] tcp: tcp_send_challenge_ack delete useless param `skb`

On Wed, Jan 5, 2022 at 4:33 PM Benjamin.Yim <yan2228598786@...il.com> wrote:
>
> From: Benjamin <yan2228598786@...il.com>
>
> After this parameter is passed in, there is no usage, and deleting it will
>  not bring any impact.
>
> Signed-off-by: Benjamin <yan2228598786@...il.com>

SGTM, thanks !
Reviewed-by: Eric Dumazet <edumazet@...gle.com>