netdev - Re: [PATCH v2 net-next 1/6] net: dsa: reorder PHY initialization with MTU setup in slave.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4a8f5b90-2fb6-ea40-c04e-25d5436f5036@gmail.com>
Date:   Wed, 5 Jan 2022 19:28:01 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Vladimir Oltean <vladimir.oltean@....com>, netdev@...r.kernel.org
Cc:     "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>
Subject: Re: [PATCH v2 net-next 1/6] net: dsa: reorder PHY initialization with
 MTU setup in slave.c



On 1/5/2022 3:11 PM, Vladimir Oltean wrote:
> In dsa_slave_create() there are 2 sections that take rtnl_lock():
> MTU change and netdev registration. They are separated by PHY
> initialization.
> 
> There isn't any strict ordering requirement except for the fact that
> netdev registration should be last. Therefore, we can perform the MTU
> change a bit later, after the PHY setup. A future change will then be
> able to merge the two rtnl_lock sections into one.
> 
> Signed-off-by: Vladimir Oltean <vladimir.oltean@....com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
-- 
Florian