netdev - Re: [PATCH net-next v3 0/6] prestera: add basic router driver support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220106201954.3b707080@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 6 Jan 2022 20:19:54 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Yevhen Orlov <yevhen.orlov@...ision.eu>
Cc:     netdev@...r.kernel.org, stephen@...workplumber.org, andrew@...n.ch,
        idosch@...sch.org, Volodymyr Mytnyk <volodymyr.mytnyk@...ision.eu>,
        Taras Chornyi <taras.chornyi@...ision.eu>,
        Mickey Rachamim <mickeyr@...vell.com>,
        Serhiy Pshyk <serhiy.pshyk@...ision.eu>,
        Taras Chornyi <tchornyi@...vell.com>,
        Oleksandr Mazur <oleksandr.mazur@...ision.eu>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3 0/6] prestera: add basic router driver
 support

On Fri,  7 Jan 2022 05:01:30 +0200 Yevhen Orlov wrote:
> Changes for v3:
> * Reverse xmas tree variables refactor
> * Make friendly NL_SET_ERR_MSG_MOD messages
> * Refactor __prestera_inetaddr_event to use early return
> * Add prestera_router_hw_fini, which verify lists are empty
> * Fix error path in __prestera_vr_create. Remove unnecessary kfree.
> * Make __prestera_vr_destroy symmetric to "create"
> * prestera_vr_put/get now using refcount_t
> * Add WARN for sanity check path in __prestera_rif_entry_key_copy
> * Make prestera_rif_entry_create followed by prestera_rif_entry_destroy
> * Add missed call prestera_router_fini in prestera_switch_fini

Thanks for the update, could you send this set as incremental changes
as the previous version appears to have been applied?