netdev - Re: [PATCH net-next v5 4/8] net/funeth: ethtool operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220106204430.3bf21da3@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 6 Jan 2022 20:44:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Dimitris Michailidis <d.michailidis@...gible.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org, andrew@...n.ch
Subject: Re: [PATCH net-next v5 4/8] net/funeth: ethtool operations

On Thu,  6 Jan 2022 20:36:08 -0800 Dimitris Michailidis wrote:
> +	if (netif_running(netdev))
> +		netdev->netdev_ops->ndo_stop(netdev);
> +
> +	old_tx = netdev->real_num_tx_queues;
> +	old_rx = netdev->real_num_rx_queues;
> +	set_ring_count(netdev, chan->tx_count, chan->rx_count);
> +
> +	if (netif_running(netdev)) {
> +		rc = netdev->netdev_ops->ndo_open(netdev);
> +		if (rc) {
> +			set_ring_count(netdev, old_tx, old_rx);
> +			netdev->netdev_ops->ndo_open(netdev);

Sorry, I wasn't clear - same story as with XDP - configuration changes
should not run at risk of having the machine drop off the network due
to temporary memory pressure.